ui: migrate route templates to gjs strict mode and stabilize regressions#27752
Draft
aklkv wants to merge 102 commits intochore/ui-drop-classic-decorators-sfcfrom
Draft
ui: migrate route templates to gjs strict mode and stabilize regressions#27752aklkv wants to merge 102 commits intochore/ui-drop-classic-decorators-sfcfrom
aklkv wants to merge 102 commits intochore/ui-drop-classic-decorators-sfcfrom
Conversation
Replace deprecated `(action ...)` helper with modern Ember patterns:
- `(action this.method)` → `this.method` with `@action` decorator
- `(action (mut this.prop))` → `(fn (mut this.prop))`
- `(action ... value=\"target.value\")` → `(pick \"target.value\" (fn (mut ...)))`
- `{{action \"method\"}}` → `{{on \"event\" this.method}}`
- `(action (queue ...))` → `(queue ...)` with `(fn (mut ...))` wrappers
Key fixes:
- Add `@action` to locally-used methods needing `this` binding
(capture, resetPagination, calculatePosition, etc.)
- Do NOT add `@action` to no-op defaults overridden by parent attrs
(onToggle, onDismiss, onHamburgerClick) - creates read-only getter
- Use `init()` + `.bind(this)` for image-file.js where method is both
locally used and overridable by parent
- Wrap bare `(mut ...)` with `(fn ...)` when passed to `pick`/`queue`
helpers that call it as a function"
aklkv
force-pushed
the
chore/ui-drop-classic-decorators-sfc
branch
from
cafcfeb to
7b778c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.